Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove codespaces and add link to k3d config #1201

Merged
merged 8 commits into from
Sep 13, 2024
Merged

Remove codespaces and add link to k3d config #1201

merged 8 commits into from
Sep 13, 2024

Conversation

Reshrahim
Copy link
Contributor

@Reshrahim Reshrahim commented Aug 20, 2024

Thank you for helping make the Radius documentation better!

Please follow this checklist before submitting:

  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

This PR removed Codespaces as it is disabled for the project. We are working with the CNCF team to get it re-enabled. Also ads link to the k3d cluster config

Issue reference

Fixes: #1171

Signed-off-by: Reshma Abdul Rahim <[email protected]>
@brooke-hamilton
Copy link
Contributor

Having the k3d cluster config link is great. 🎸

Comment on lines 19 to 24
{{< alert title="🚀 Run in a <b>free</b> GitHub Codespace" color="primary" >}}
The Radius getting-started guide can be [run **for free** in a GitHub Codespace](https://github.blog/changelog/2022-11-09-codespaces-for-free-and-pro-accounts/). Visit the following link to get started in seconds:

[![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/radius-project/samples)
{{< /alert >}}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should comment this out for now in case we figure out a solution to enable users to leverage codespaces again?

Signed-off-by: Reshma Abdul Rahim <[email protected]>
Signed-off-by: Reshma Abdul Rahim <[email protected]>
Signed-off-by: Reshma Abdul Rahim <[email protected]>
@Reshrahim Reshrahim merged commit a772ba7 into v0.37 Sep 13, 2024
9 checks passed
@Reshrahim Reshrahim deleted the re/firstapp branch September 13, 2024 17:31
ytimocin added a commit that referenced this pull request Sep 13, 2024
* Update docs for v0.37.0

* Update index.md (#1203)

Signed-off-by: Reshma Abdul Rahim <[email protected]>

* Bump micromatch from 4.0.4 to 4.0.8 in /docs (#1210)

Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.4 to 4.0.8.
- [Release notes](https://github.com/micromatch/micromatch/releases)
- [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md)
- [Commits](micromatch/micromatch@4.0.4...4.0.8)

---
updated-dependencies:
- dependency-name: micromatch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Reshma Abdul Rahim <[email protected]>

* Remove codespaces and add link to k3d config  (#1201)

* Update index.md

Signed-off-by: Reshma Abdul Rahim <[email protected]>

* Update docs/content/getting-started/index.md

Signed-off-by: Reshma Abdul Rahim <[email protected]>

* Update index.md

Signed-off-by: Reshma Abdul Rahim <[email protected]>

* Update index.md

Signed-off-by: Reshma Abdul Rahim <[email protected]>

* Update index.md

Signed-off-by: Reshma Abdul Rahim <[email protected]>

* Update docs/content/getting-started/index.md

Signed-off-by: Will <[email protected]>

---------

Signed-off-by: Reshma Abdul Rahim <[email protected]>
Signed-off-by: Will <[email protected]>
Co-authored-by: Will <[email protected]>

* Reverting some changes

Signed-off-by: ytimocin <[email protected]>

---------

Signed-off-by: Reshma Abdul Rahim <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Will <[email protected]>
Signed-off-by: ytimocin <[email protected]>
Co-authored-by: Reshma Abdul Rahim <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Will <[email protected]>
Co-authored-by: ytimocin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting Started page recommends k3d without a reference to required k3d configuration
3 participants